-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2456, 2466, 2469, 2470] Fixes on reference widget #2478
Conversation
6ebff75
to
a02c97b
Compare
cy.getByTestId('selected').findByTestId('Entity2').should('exist'); | ||
}); | ||
|
||
it.only('check widget reference filter ancestor only for containment reference', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it.only
should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
INVALID_INPUT = Invalid input type, "{0}" has been received while "{1}" was expected | ||
UNEXPECTED_ERROR = An unexpected error has occurred, please contact the server administrator | ||
INVALID_NUMBER = The new value "{0}" is not a valid number | ||
UPPER_BOUNDARY_REACHED = Unable to create a new instance of "{0}" in feature "{1}" because it has reach its upper-bound cardinality." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The final "
is not neeed; it shows as part of the message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -39,12 +39,17 @@ public String unexpectedError() { | |||
|
|||
@Override | |||
public String invalidInput(String expectedInputTypeName, String receivedInputTypeName) { | |||
return this.messageSourceAccessor.getMessage("INVALID_INPUT", new Object[] { expectedInputTypeName, receivedInputTypeName }); | |||
return this.messageSourceAccessor.getMessage("INVALID_INPUT", new Object[]{expectedInputTypeName, receivedInputTypeName}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Eclipse formatting profile keeps the spaces between [
, {
, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done,
I've changed my format settings
a848385
to
52a14ca
Compare
I'll merge once the build is green. |
…e from the reference widget Bug: #2470 Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
…et to a filtered item in the explorer Bug: #2469 Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
… reference widget Bug: #2466 Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
…o a mono reference no empty Bug: #2456 Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
…he option list in a reference widget modal transfert Bug: #2487 Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
52a14ca
to
41a9549
Compare
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:
andpr:
labels been added to the pull request? (In case of doubt, start with the labelspriority: low
andpr: to review later
)area:
,difficulty:
,type:
)CHANGELOG.adoc
been updated to reference the relevant issues?CHANGELOG.adoc
? (Including changes in the GraphQL API)CHANGELOG.adoc
? For example indoc/screenshots/2022.5.0-my-new-feature.png
Architectural decision records (ADR)
[doc]
?CHANGELOG.adoc
?Dependencies
CHANGELOG.adoc
?CHANGELOG.adoc
?Frontend
This section is not relevant if your contribution does not come with changes to the frontend.
General purpose
Typing
We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).
useMutation<DATA_TYPE, VARIABLE_TYPE>(…)
useQuery<DATA_TYPE, VARIABLE_TYPE>(…)
useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)
useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)
useState<STATE_TYPE>(…)
?.
(if the GraphQL API specifies that a field cannot benull
, do not treat it has potentiallynull
for example)let diagram: Diagram | null = null;
)Backend
This section is not relevant if your contribution does not come with changes to the backend.
General purpose
Architecture
Review
How to test this PR?
Please describe here the various use cases to test this pull request